Ci/homogenize workflows with GC.OS repositories#702
Ci/homogenize workflows with GC.OS repositories#702tingiskhan wants to merge 11 commits intoPyPortfolio:mainfrom
Conversation
|
@fkiraly Would it make sense to have a dedicated devops repo associated with sktime where re-usable workflow components are stored? |
Yes, that sounds like an excellent idea. I think @tschm has set this up for their repos. However, I think it is not a priority currently when compared to getting ppfopt back on track. |
fkiraly
changed the title
fkiraly
added
the
maintenance
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| enable-cache: true | ||
|
|
| run: uv pip install ".[dev,all_extras]" --no-cache-dir | ||
| env: | ||
| UV_SYSTEM_PYTHON: 1 | ||
| run: uv sync --extra all_extras --extra dev --no-cache |
There was a problem hiding this comment.
I would go for uv pip install rather than uv sync. See long discussion on the topic in sktime.
| line-ending = "auto" | ||
| skip-magic-trailing-comma = false | ||
|
|
||
| [dependency-groups] |
There was a problem hiding this comment.
why move it here? I think we should just leave it in non-uv format
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Thanks!
Looks mostly good, but in some places it notably diverges from the "close to pip setup" to more uv based idioms. I think these may be problematic and shuld be reverted:
- use of
uv syncinstead ofuv pip install, this can cause problems with incompatible depsets - use of
uvdepset definition inpyproject.tomlwhich no longer conforms with PEP
2 participants
Homogenizes the main workflows of pyportfolioopt with that of GC.OS repositories - template used is
sktime@fkiraly